Maximum Length Undefined (v3)

  • Query id: 8c8261c2-19a9-4ef7-ad37-b8bc7bdd4d85
  • Query name: Maximum Length Undefined (v3)
  • Platform: OpenAPI
  • Severity: Medium
  • Category: Insecure Configurations
  • URL: Github

Description

String schema should have 'maxLength' defined.
Documentation

Code samples

Code samples with security vulnerabilities

Positive test num. 1 - json file
{
  "openapi": "3.0.0",
  "info": {
    "title": "Simple API Overview",
    "version": "1.0.0",
    "contact": {
      "name": "contact",
      "url": "https://www.google.com/",
      "email": "user@gmail.com"
    }
  },
  "paths": {
    "/": {
      "get": {
        "operationId": "listVersionsv2",
        "summary": "List API versions",
        "responses": {
          "200": {
            "description": "200 response",
            "content": {
              "application/json": {
                "examples": {
                  "foo": {
                    "value": {
                      "versions": [
                        {
                          "status": "CURRENT",
                          "updated": "2011-01-21T11:33:21Z",
                          "id": "v2.0",
                          "links": [
                            {
                              "href": "http://127.0.0.1:8774/v2/",
                              "rel": "self"
                            }
                          ]
                        }
                      ]
                    }
                  }
                }
              }
            }
          }
        }
      }
    }
  },
  "components": {
    "schemas": {
      "GeneralError": {
        "type": "object",
        "discriminator": {
          "propertyName": "petType"
        },
        "additionalProperties": false,
        "properties": {
          "code": {
            "type": "string",
            "format": "int32"
          },
          "message": {
            "type": "string"
          }
        },
        "required": [
          "petType"
        ]
      }
    },
    "requestBodies": {
      "NewItem": {
        "description": "A JSON object containing item data",
        "required": true,
        "content": {
          "multipart/form-data": {
            "schema": {
              "$ref": "#/components/schemas/GeneralError"
            }
          }
        }
      }
    }
  }
}
Positive test num. 2 - json file
{
  "openapi": "3.0.0",
  "info": {
    "title": "Simple API Overview",
    "version": "1.0.0",
    "contact": {
      "name": "contact",
      "url": "https://www.google.com/",
      "email": "user@gmail.com"
    }
  },
  "paths": {
    "/": {
      "get": {
        "responses": {
          "200": {
            "description": "200 response",
            "content": {
              "application/json": {
                "schema": {
                  "discriminator": {
                    "propertyName": "petType"
                  },
                  "additionalProperties": false,
                  "properties": {
                    "code": {
                      "type": "string",
                      "format": "int32"
                    },
                    "message": {
                      "type": "string"
                    }
                  },
                  "required": [
                    "petType"
                  ],
                  "type": "object"
                },
                "examples": {
                  "foo": {
                    "value": {
                      "versions": [
                        {
                          "status": "CURRENT",
                          "updated": "2011-01-21T11:33:21Z",
                          "id": "v2.0",
                          "links": [
                            {
                              "href": "http://127.0.0.1:8774/v2/",
                              "rel": "self"
                            }
                          ]
                        }
                      ]
                    }
                  }
                }
              }
            }
          }
        },
        "operationId": "listVersionsv2",
        "summary": "List API versions"
      }
    }
  }
}
Positive test num. 3 - yaml file
openapi: 3.0.0
info:
  title: Simple API Overview
  version: 1.0.0
paths:
  "/":
    get:
      operationId: listVersionsv2
      summary: List API versions
      responses:
        "200":
          description: 200 response
          content:
            application/json:
              examples:
                foo:
                  value:
                    versions:
                      - status: CURRENT
                        updated: "2011-01-21T11:33:21Z"
                        id: v2.0
                        links:
                          - href: http://127.0.0.1:8774/v2/
                            rel: self
components:
  schemas:
    GeneralError:
      type: object
      discriminator:
        propertyName: petType
      additionalProperties: false
      properties:
        code:
          type: string
          format: int32
        message:
          type: string
      required:
        - petType
  requestBodies:
    NewItem:
      description: A JSON object containing item data
      required: true
      content:
        multipart/form-data:
          schema:
            $ref: "#/components/schemas/GeneralError"

Positive test num. 4 - yaml file
openapi: 3.0.0
info:
  title: Simple API Overview
  version: 1.0.0
paths:
  "/":
    get:
      operationId: listVersionsv2
      summary: List API versions
      responses:
        "200":
          description: 200 response
          content:
            application/json:
              schema:
                type: object
                discriminator:
                  propertyName: petType
                additionalProperties: false
                properties:
                  code:
                    type: string
                    format: int32
                  message:
                    type: string
                required:
                  - petType
              examples:
                foo:
                  value:
                    versions:
                      - status: CURRENT
                        updated: "2011-01-21T11:33:21Z"
                        id: v2.0
                        links:
                          - href: http://127.0.0.1:8774/v2/
                            rel: self
Positive test num. 5 - json file
{
  "swagger": "2.0",
  "info": {
    "title": "Simple API Overview",
    "version": "1.0.0",
    "contact": {
      "name": "contact",
      "url": "https://www.google.com/",
      "email": "user@gmail.com"
    }
  },
  "paths": {
    "/": {
      "get": {
        "responses": {
          "200": {
            "description": "200 response",
            "schema": {
              "discriminator": "petType",
              "additionalProperties": false,
              "properties": {
                "code": {
                  "type": "string",
                  "format": "int32"
                },
                "message": {
                  "type": "string"
                }
              },
              "required": [
                "petType"
              ],
              "type": "object"
            }
          }
        }
      }
    }
  }
}
Positive test num. 6 - yaml file
swagger: "2.0"
info:
  title: Simple API Overview
  version: 1.0.0
paths:
  "/":
    get:
      operationId: listVersionsv2
      summary: List API versions
      responses:
        "200":
          description: 200 response
          schema:
            type: object
            discriminator: petType
            additionalProperties: false
            properties:
              code:
                type: string
                format: int32
              message:
                type: string
            required:
              - petType
Positive test num. 7 - json file
{
  "swagger": "2.0",
  "info": {
    "title": "Simple API Overview",
    "version": "1.0.0",
    "contact": {
      "name": "contact",
      "url": "https://www.google.com/",
      "email": "user@gmail.com"
    }
  },
  "paths": {
    "/": {
      "get": {
        "responses": {
          "200": {
            "description": "200 response",
            "schema": {
              "discriminator": "petType",
              "additionalProperties": false,
              "properties": {
                "code": {
                  "type": "string",
                  "format": "int32",
                  "pattern": "[a-z0-9-]*"
                },
                "message": {
                  "type": "string",
                  "pattern": "[a-z]{3,}"
                }
              },
              "required": [
                "petType"
              ],
              "type": "object"
            }
          }
        }
      }
    }
  }
}
Positive test num. 8 - json file
{
  "swagger": "2.0",
  "info": {
    "title": "Simple API Overview",
    "version": "1.0.0",
    "contact": {
      "name": "contact",
      "url": "https://www.google.com/",
      "email": "user@gmail.com"
    }
  },
  "paths": {
    "/": {
      "get": {
        "responses": {
          "200": {
            "description": "200 response",
            "schema": {
              "discriminator": "petType",
              "additionalProperties": false,
              "properties": {
                "code": {
                  "type": "string",
                  "format": "int32",
                  "pattern": "[a-z0-9-]{2,3}"
                },
                "message": {
                  "type": "string",
                  "pattern": "[a-z]+"
                }
              },
              "required": [
                "petType"
              ],
              "type": "object"
            }
          }
        }
      }
    }
  }
}
Positive test num. 9 - json file
{
  "components": {
    "securitySchemes": {
      "Basic1": {
        "scheme": "basic",
        "type": "http"
      },
      "JWT1": {
        "scheme": "basic",
        "type": "http"
      },
      "JWT1-1": {
        "bearerFormat": "JWT",
        "scheme": "bearer",
        "type": "http"
      }
    }
  },
  "info": {
    "description": "Swagger auto-generated from learnt schema for ves-io-demo-app-waap-sentence-api",
    "title": "ves-io-demo-app-waap-sentence-api",
    "version": "2023-06-21 13:26:46"
  },
  "openapi": "3.0.3",
  "paths": {
    "/api/adjectives": {
      "get": {
        "description": "Swagger auto-generated from learnt schema",
        "parameters": [
          {
            "description": "IPv4 Address",
            "in": "header",
            "name": "xff",
            "schema": {
              "pattern": "(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.){3}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)",
              "type": "string",
              "x-pii": {}
            }
          },
          {
            "description": "Word",
            "in": "header",
            "name": "x-f5-request-id",
            "schema": {
              "pattern": "[a-z0-9-]+",
              "type": "string"
            }
          },
          {
            "description": "Word",
            "in": "cookie",
            "name": "_imp_apg_r_",
            "schema": {
              "pattern": "[a-z0-9-]+",
              "type": "string"
            }
          }
        ],
        "responses": {
          "default": {
            "description": ""
          }
        },
        "security": [
          {
            "JWT1": []
          }
        ]
      }
    }
  },
  "servers": [
  ]
}

Code samples without security vulnerabilities

Negative test num. 1 - json file
{
  "openapi": "3.0.0",
  "info": {
    "title": "Simple API Overview",
    "version": "1.0.0",
    "contact": {
      "name": "contact",
      "url": "https://www.google.com/",
      "email": "user@gmail.com"
    }
  },
  "paths": {
    "/": {
      "get": {
        "operationId": "listVersionsv2",
        "summary": "List API versions",
        "responses": {
          "200": {
            "description": "200 response",
            "content": {
              "application/json": {
                "examples": {
                  "foo": {
                    "value": {
                      "versions": [
                        {
                          "status": "CURRENT",
                          "updated": "2011-01-21T11:33:21Z",
                          "id": "v2.0",
                          "links": [
                            {
                              "href": "http://127.0.0.1:8774/v2/",
                              "rel": "self"
                            }
                          ]
                        }
                      ]
                    }
                  }
                }
              }
            }
          }
        }
      }
    }
  },
  "components": {
    "schemas": {
      "GeneralError": {
        "type": "object",
        "discriminator": {
          "propertyName": "petType"
        },
        "additionalProperties": false,
        "properties": {
          "code": {
            "type": "string",
            "maxLength": 15,
            "format": "int32"
          },
          "message": {
            "type": "string",
            "maxLength": 15
          }
        },
        "required": [
          "petType"
        ]
      }
    },
    "requestBodies": {
      "NewItem": {
        "description": "A JSON object containing item data",
        "required": true,
        "content": {
          "multipart/form-data": {
            "schema": {
              "$ref": "#/components/schemas/GeneralError"
            }
          }
        }
      }
    }
  }
}
Negative test num. 2 - json file
{
  "openapi": "3.0.0",
  "info": {
    "title": "Simple API Overview",
    "version": "1.0.0",
    "contact": {
      "name": "contact",
      "url": "https://www.google.com/",
      "email": "user@gmail.com"
    }
  },
  "paths": {
    "/": {
      "get": {
        "responses": {
          "200": {
            "description": "200 response",
            "content": {
              "application/json": {
                "schema": {
                  "discriminator": {
                    "propertyName": "petType"
                  },
                  "additionalProperties": false,
                  "properties": {
                    "code": {
                      "type": "string",
                      "format": "int32",
                      "maxLength": 15
                    },
                    "message": {
                      "type": "string",
                      "maxLength": 15
                    }
                  },
                  "required": [
                    "petType"
                  ],
                  "type": "object"
                },
                "examples": {
                  "foo": {
                    "value": {
                      "versions": [
                        {
                          "status": "CURRENT",
                          "updated": "2011-01-21T11:33:21Z",
                          "id": "v2.0",
                          "links": [
                            {
                              "href": "http://127.0.0.1:8774/v2/",
                              "rel": "self"
                            }
                          ]
                        }
                      ]
                    }
                  }
                }
              }
            }
          }
        }
      }
    }
  }
}
Negative test num. 3 - yaml file
openapi: 3.0.0
info:
  title: Simple API Overview
  version: 1.0.0
paths:
  "/":
    get:
      operationId: listVersionsv2
      summary: List API versions
      responses:
        "200":
          description: 200 response
          content:
            application/json:
              examples:
                foo:
                  value:
                    versions:
                      - status: CURRENT
                        updated: "2011-01-21T11:33:21Z"
                        id: v2.0
                        links:
                          - href: http://127.0.0.1:8774/v2/
                            rel: self
components:
  schemas:
    GeneralError:
      type: object
      discriminator:
        propertyName: petType
      additionalProperties: false
      properties:
        code:
          type: string
          maxLength: 15
          format: int32
        message:
          type: string
          maxLength: 15
      required:
        - petType
  requestBodies:
    NewItem:
      description: A JSON object containing item data
      required: true
      content:
        multipart/form-data:
          schema:
            $ref: "#/components/schemas/GeneralError"

Negative test num. 4 - yaml file
openapi: 3.0.0
info:
  title: Simple API Overview
  version: 1.0.0
paths:
  "/":
    get:
      operationId: listVersionsv2
      summary: List API versions
      responses:
        "200":
          description: 200 response
          content:
            application/json:
              schema:
                type: object
                discriminator:
                  propertyName: petType
                additionalProperties: false
                properties:
                  code:
                    type: string
                    format: int32
                    maxLength: 15
                  message:
                    type: string
                    maxLength: 15
                required:
                  - petType
              examples:
                foo:
                  value:
                    versions:
                      - status: CURRENT
                        updated: "2011-01-21T11:33:21Z"
                        id: v2.0
                        links:
                          - href: http://127.0.0.1:8774/v2/
                            rel: self
components:
  schemas:
    GeneralError:
      type: object
      discriminator:
        propertyName: petType
      additionalProperties: false
      properties:
        code:
          type: string
          format: int32
          maxLength: 15
        message:
          type: string
          maxLength: 15
      required:
        - petType
Negative test num. 5 - json file
{
  "swagger": "2.0",
  "info": {
    "title": "Simple API Overview",
    "version": "1.0.0",
    "contact": {
      "name": "contact",
      "url": "https://www.google.com/",
      "email": "user@gmail.com"
    }
  },
  "paths": {
    "/": {
      "get": {
        "responses": {
          "200": {
            "description": "200 response",
            "schema": {
              "discriminator": "petType",
              "additionalProperties": false,
              "properties": {
                "code": {
                  "type": "string",
                  "format": "int32",
                  "maxLength": 15
                },
                "message": {
                  "type": "string",
                  "maxLength": 15
                }
              },
              "required": [
                "petType"
              ],
              "type": "object"
            }
          }
        }
      }
    }
  }
}
Negative test num. 6 - yaml file
swagger: "2.0"
info:
  title: Simple API Overview
  version: 1.0.0
paths:
  "/":
    get:
      operationId: listVersionsv2
      summary: List API versions
      responses:
        "200":
          description: 200 response
          schema:
            type: object
            discriminator: petType
            additionalProperties: false
            properties:
              code:
                type: string
                format: int32
                maxLength: 15
              message:
                type: string
                maxLength: 15
            required:
              - petType
Negative test num. 7 - json file
{
  "swagger": "2.0",
  "info": {
    "title": "Simple API Overview",
    "version": "1.0.0",
    "contact": {
      "name": "contact",
      "url": "https://www.google.com/",
      "email": "user@gmail.com"
    }
  },
  "paths": {
    "/": {
      "get": {
        "responses": {
          "200": {
            "description": "200 response",
            "schema": {
              "discriminator": "petType",
              "additionalProperties": false,
              "properties": {
                "code": {
                  "type": "string",
                  "format": "int32",
                  "pattern": "[a-z0-9-]"
                },
                "message": {
                  "type": "string",
                  "pattern": "[a-z]{3}"
                }
              },
              "required": [
                "petType"
              ],
              "type": "object"
            }
          }
        }
      }
    }
  }
}
Negative test num. 8 - json file
{
  "swagger": "2.0",
  "info": {
    "title": "Simple API Overview",
    "version": "1.0.0",
    "contact": {
      "name": "contact",
      "url": "https://www.google.com/",
      "email": "user@gmail.com"
    }
  },
  "paths": {
    "/": {
      "get": {
        "responses": {
          "200": {
            "description": "200 response",
            "schema": {
              "discriminator": "petType",
              "additionalProperties": false,
              "properties": {
                "code": {
                  "type": "string",
                  "format": "int32",
                  "pattern": "[a-z0-9-]?"
                },
                "message": {
                  "type": "string",
                  "pattern": "[a-z]\\{2,\\}"
                }
              },
              "required": [
                "petType"
              ],
              "type": "object"
            }
          }
        }
      }
    }
  }
}