Cleartext API Key In Operation Security (v3)

• Query id: d90d4e40-44c1-4125-87a0-e072c3e195b5
• Query name: Cleartext API Key In Operation Security (v3)
• Platform: OpenAPI
• Severity: High
• Category: Access Control
• URL: Github

Description

API Keys should not be sent as cleartext over an unencrypted channel
Documentation

Code samples

Code samples with security vulnerabilities

Positive test num. 1 - json file

{
  "openapi": "3.0.0",
  "info": {
    "title": "Simple API overview",
    "version": "1.0.0"
  },
  "paths": {
    "/pets": {
      "post": {
        "description": "Creates a new pet in the store",
        "responses": {
          "200": {
            "description": "200 response"
          }
        },
        "operationId": "addPet",
        "security": [
          {
            "apiKey1": [],
            "apiKey2": [],
            "apiKey3": []
          }
        ]
      }
    }
  },
  "components": {
    "securitySchemes": {
      "apiKey1": {
        "type": "apiKey",
        "name": "X-API-Key",
        "in": "header"
      },
      "apiKey2": {
        "type": "apiKey",
        "name": "X-API-Key",
        "in": "cookie"
      },
      "apiKey3": {
        "type": "apiKey",
        "name": "X-API-Key",
        "in": "query"
      }
    }
  }
}

Positive test num. 2 - yaml file

openapi: 3.0.0
info:
  title: Simple API overview
  version: 1.0.0
paths:
  /pets:
    post:
      description: Creates a new pet in the store
      responses:
        "200":
          description: 200 response
      operationId: addPet
      security:
        - apiKey1: []
          apiKey2: []
          apiKey3: []
components:
  securitySchemes:
    apiKey1:
      type: apiKey
      name: X-API-Key
      in: header
    apiKey2:
      type: apiKey
      name: X-API-Key
      in: cookie
    apiKey3:
      type: apiKey
      name: X-API-Key
      in: query

Positive test num. 3 - json file

{
  "swagger": "2.0",
  "info": {
    "title": "Simple API overview",
    "version": "1.0.0"
  },
  "paths": {
    "/pets": {
      "post": {
        "description": "Creates a new pet in the store",
        "responses": {
          "200": {
            "description": "200 response"
          }
        },
        "operationId": "addPet",
        "security": [
          {
            "apiKey1": [],
            "apiKey3": []
          }
        ]
      }
    }
  },
  "securityDefinitions": {
    "apiKey1": {
      "type": "apiKey",
      "name": "X-API-Key",
      "in": "header"
    },
    "apiKey3": {
      "type": "apiKey",
      "name": "X-API-Key",
      "in": "query"
    }
  }
}

Positive test num. 4 - yaml file

swagger: "2.0"
info:
  title: Simple API overview
  version: 1.0.0
paths:
  /pets:
    post:
      description: Creates a new pet in the store
      responses:
        "200":
          description: 200 response
      operationId: addPet
      security:
        - apiKey1: []
          apiKey3: []
securityDefinitions:
  apiKey1:
    type: apiKey
    name: X-API-Key
    in: header
  apiKey3:
    type: apiKey
    name: X-API-Key
    in: query

Code samples without security vulnerabilities

Negative test num. 1 - json file

{
  "openapi": "3.0.0",
  "info": {
    "version": "1.0.0",
    "title": "Simple API overview"
  },
  "paths": {
    "/pets": {
      "post": {
        "description": "Creates a new pet in the store",
        "responses": {
          "200": {
            "description": "200 response"
          }
        },
        "operationId": "addPet",
        "security": [
          {
            "OAuth2": [
              "write",
              "read"
            ]
          }
        ]
      }
    }
  },
  "components": {
    "securitySchemes": {
      "OAuth2": {
        "type": "oauth2",
        "flows": {
          "authorizationCode": {
            "scopes": {
              "write": "modify objects in your account",
              "read": "read objects in your account"
            },
            "authorizationUrl": "https://example.com/oauth/authorize",
            "tokenUrl": "https://example.com/oauth/token"
          }
        }
      }
    }
  }
}

Negative test num. 2 - yaml file

openapi: 3.0.0
info:
  title: Simple API overview
  version: 1.0.0
paths:
  /pets:
    post:
      description: Creates a new pet in the store
      responses:
        "200":
          description: 200 response
      operationId: addPet
      security:
        - OAuth2:
            - write
            - read
components:
  securitySchemes:
    OAuth2:
      type: oauth2
      flows:
        authorizationCode:
          scopes:
            write: modify objects in your account
            read: read objects in your account
          authorizationUrl: https://example.com/oauth/authorize
          tokenUrl: https://example.com/oauth/token

Negative test num. 3 - json file

{
  "swagger": "2.0",
  "info": {
    "version": "1.0.0",
    "title": "Simple API overview"
  },
  "paths": {
    "/pets": {
      "post": {
        "description": "Creates a new pet in the store",
        "responses": {
          "200": {
            "description": "200 response"
          }
        },
        "operationId": "addPet",
        "security": [
          {
            "OAuth2": [
              "write",
              "read"
            ]
          }
        ]
      }
    }
  },
  "securityDefinitions": {
    "OAuth2": {
      "type": "oauth2",
      "flow": "accessCode",
      "authorizationUrl": "https://example.com/oauth/authorize",
      "tokenUrl": "https://example.com/oauth/token",
      "scopes": {
        "read": "Grants read access",
        "write": "Grants write access"
      }
    }
  }
}

Negative test num. 4 - yaml file

swagger: "2.0"
info:
  title: Simple API overview
  version: 1.0.0
paths:
  /pets:
    post:
      description: Creates a new pet in the store
      responses:
        "200":
          description: 200 response
      operationId: addPet
      security:
        - OAuth2:
            - write
            - read
securityDefinitions:
  OAuth2:
    type: oauth2
    flow: accessCode
    authorizationUrl: https://example.com/oauth/authorize
    tokenUrl: https://example.com/oauth/token
    scopes:
      read: Grants read access
      write: Grants write access